Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] feat/restore critical exp #667

Merged

Conversation

gid-sentry
Copy link
Contributor

Pulling in Sergio's changes with (very slight) modifications in order to be able to restore the critical experience dashboard and build some workflows utilizing the new EAP functionality.

Copy link

vercel bot commented Jan 22, 2025

@gid-sentry is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@ndmanvar
Copy link
Collaborator

@gid-sentry - looks like we have some conflicts that we need to resolve..
and also, let's remove the log statements if we don't need them 😉

@gid-sentry
Copy link
Contributor Author

Conflicts should be fixed now I believe

Copy link
Collaborator

@realkosty realkosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I checked it out locally and it's failing to build

Screenshot 2025-01-24 at 3 33 52 PM

react/config-overrides.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 29, 2025

Bundle Report

Changes will decrease total bundle size by 5.06kB (-0.36%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
empower-react-app-array-push 1.42MB -5.06kB (-0.36%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: empower-react-app-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/js/main.*.js -5.06kB 550.4kB -0.91%

@gid-sentry
Copy link
Contributor Author

@realkosty should be all set now!

@realkosty
Copy link
Collaborator

@ndmanvar

so npm test --coverage will return exit code 1 if one of the tests fails.
I think we should fix this once and for all:

#670 (make sure coverage report succeeds even if some test fails)

#669 (actually fixes test FWIW)

@realkosty
Copy link
Collaborator

@realkosty should be all set now!

sweet, all looks 👍👍

@realkosty realkosty merged commit 9f4a850 into sentry-demos:master Jan 29, 2025
4 of 5 checks passed
Copy link

sentry-io bot commented Jan 29, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: t.getAttribute is not a function /checkout View Issue
  • ‼️ Error: app unable to load products: TypeError: e.reviews.reduce is not a function /products-fes View Issue
  • ‼️ TypeError: Failed to fetch /products-fes View Issue
  • ‼️ TypeError: Failed to fetch /products View Issue
  • ‼️ Error: app unable to load products: TypeError: e.reviews.reduce is not a function /products-fes View Issue

Did you find this useful? React with a 👍 or 👎

@ndmanvar
Copy link
Collaborator

dude we got a supect issue, which confirms this is deployed

bammmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants