[platf,react] fix double-upload of source maps, template-ize webpack config #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realkosty
force-pushed
the
react-upgrade-node-js-and-sentry-webpack-plugin
branch
from
21b11bd to
29d5bdc
Compare
realkosty
force-pushed
the
react-fix-sourcemap-double-upload
branch
from
0e2961e to
e71a936
Compare
cstavitsky
approved these changes
Mar 19, 2024
Base automatically changed from
react-upgrade-node-js-and-sentry-webpack-plugin
to
master
March 20, 2024 00:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourcemaps looked broken in local and staging
Code would show up unminified but UI would not show stack trace linking, sourcemaps troubleshooting modal wizard instead. So wasn't possible to test stack trace linking/VCS integrations or Codecov integration locally.
Was introduced in: #236
Note: I know
deploy.shlogic is getting pretty ugly. I have a plan to make it much prettier, calledenvdot, it's quite elegant. One day.Testing
Tested together with other changes in #417