[react] Fix grouping by SE "supertag" #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2024
realkosty
force-pushed
the
react-fix-se-grouping
branch
from
dc365fa to
4fa52ea
Compare
realkosty
changed the base branch from
master
to
react-fix-sourcemap-double-upload
realkosty
force-pushed
the
react-fix-sourcemap-double-upload
branch
from
0e2961e to
e71a936
Compare
realkosty
force-pushed
the
react-fix-se-grouping
branch
from
4fa52ea to
252535f
Compare
cstavitsky
reviewed
Mar 19, 2024
cstavitsky
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After TDA started using the new SE "supertag" format (#332) we're having multiple issues for same flagship error, 1 for each browser/platform combination. This fixes it.
Testing
Note
Tested together with 2 other PRs: #422 and #423
./deploy.sh --env=local reactexample event
./deploy.sh --env=staging reacthttps://staging-application-monitoring-react-dot-sales-engineering-sf.appspot.com/products?se=kosty_node_18_webpack_se&backend=rails
Test error
Test transaction
Test error with 'prod-tda-direct-*' se tag to test grouping signature