Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw error when analytics are disabled. #901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not throw error when analytics are disabled. #901

wants to merge 2 commits into from

Commits on Jul 15, 2023

  1. Do not throw error when analytics are disabled. 

    Imagine the following case where you disable segment in your code.

const { Analytics } = require('@segment/analytics-node');
new Analytics({ writeKey: processe.env.WRITE_KEY || '', disable: true });

If WRITE_KEY is not present, but your analytics are disabled this still throws an error.

This would simplify local setups and do not force them to have a truthy string as write key
    @Pruxis
    Pruxis authored Jul 15, 2023
    Configuration menu
    Copy the full SHA
    af17024 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Add changeset

    @chrisradek
    chrisradek authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d25217d View commit details
    Browse the repository at this point in the history