Do not throw error when analytics are disabled. #901
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine the following case where you disable segment in your code.
const { Analytics } = require('@segment/analytics-node');
new Analytics({ writeKey: processe.env.WRITE_KEY || '', disable: true });
If WRITE_KEY is not present, but your analytics are disabled this still throws an error.
This would simplify local setups and do not force them to have a truthy string as write key
🦋 Changeset detectedLatest commit: d25217d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Runtime only; no Typescript changes are needed here IMO. |
|
@silesky Do I need to write some tests to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine the following case where you disable segment in your code.
const { Analytics } = require('@segment/analytics-node');
new Analytics({ writeKey: processe.env.WRITE_KEY || '', disable: true });
If WRITE_KEY is not present, but your analytics are disabled this still throws an error.
This would simplify local setups and do not force them to have a truthy string as write key