Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check status and pass headers when proxy-streaming from file-store #17

Open
wants to merge 3 commits into
base: sa_patches_6.3.3
Choose a base branch
from
Open

Check status and pass headers when proxy-streaming from file-store #17

wants to merge 3 commits into from

Commits on Sep 3, 2023

  1. PATCH: AR-3088 Customize the Welcome message on the login screen 

    The login form now shows a lengthy welcome message, hardcoded to:

	> Welcome to {siteName} workspace

where {siteName} is currently "Seeking Alpha Chat".
I find the text of "workspace" to be awkward, but it's not configurable.

There is an option to disable it entirely, but then it looks empty.
There used to be a large SA logo, but they've shrunk the logo down considerably.

I would like the text:

	> Seeking Alpha
	> Investing Groups

However, left as a single line, those four words don't wrap at the right point.
Use HTML to explicitly break it at the right point.
    @nmagedman
    nmagedman committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    dbfba6b View commit details
    Browse the repository at this point in the history

  2. PATCH: AR-3091 Login form "Email or username" label incorrect 

    Our hack to the login form currently only supports identifying the user
by email address, not by username.  Until that is fixed, we should change
the field label to read "Email address" rather than "Email or username".

Concurrent with this patch, we should remove the custom configuration
for `Accounts_EmailOrUsernamePlaceholder`, returning it to the default empty string.
We had customized it "Email address" when 5.x treated the empty string as "Email or username".
However 6.x treats the empty string as "[email protected]".
    @nmagedman
    nmagedman committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    7b784aa View commit details
    Browse the repository at this point in the history

  3. Check status and pass headers when proxy-streaming from file-store 

    Before this change, when there was any issue during proxy, `fileRes.pipe` might have proxied 0 bytes, or proxy error body from store with status 200.

Such issues might be temporary, for example due to eventual consistency on S3 upload, but because  the response status is 200 and caching headers are set for a year, this can cause invalid response to be cached forever when using cdn-cache.
    @kapcod
    kapcod committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    4908c16 View commit details
    Browse the repository at this point in the history