Check status and pass headers when proxy-streaming from file-store #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login form now shows a lengthy welcome message, hardcoded to:
> Welcome to {siteName} workspace
where {siteName} is currently "Seeking Alpha Chat".
I find the text of "workspace" to be awkward, but it's not configurable.
There is an option to disable it entirely, but then it looks empty.
There used to be a large SA logo, but they've shrunk the logo down considerably.
I would like the text:
> Seeking Alpha
> Investing Groups
However, left as a single line, those four words don't wrap at the right point.
Use HTML to explicitly break it at the right point.
Our hack to the login form currently only supports identifying the user by email address, not by username. Until that is fixed, we should change the field label to read "Email address" rather than "Email or username". Concurrent with this patch, we should remove the custom configuration for `Accounts_EmailOrUsernamePlaceholder`, returning it to the default empty string. We had customized it "Email address" when 5.x treated the empty string as "Email or username". However 6.x treats the empty string as "[email protected]".
Before this change, when there was any issue during proxy, `fileRes.pipe` might have proxied 0 bytes, or proxy error body from store with status 200. Such issues might be temporary, for example due to eventual consistency on S3 upload, but because the response status is 200 and caching headers are set for a year, this can cause invalid response to be cached forever when using cdn-cache.
nmagedman
force-pushed
the
sa_patches_6.3.3
branch
from
7b784aa
to
d5f7da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when there was any issue during proxy,
fileRes.pipemight have proxied 0 bytes, or proxy error body from store with status 200.Such issues might be temporary, for example due to eventual consistency on S3 upload, but because the response status is 200 and caching headers are set for a year, this can cause invalid response to be cached forever when using cdn-cache.