Use lubridate package for all POSIXct conversions (updated) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better reliability, the columns names in sqldf queries should be escaped by backticks (i.e., gravis accents). This patch also incorporates the changes from commit 3c878f1. Signed-off-by: Claus Hunsen <[email protected]>
To be more reliable regarding the parsing and printing of dates, we
introduce three functions to the misc module, all using the package
'lubridate' to achieve the task:
- get.date.from.string: Parses a date string to a POSIXct object.
- get.date.from.unix.timestamp: Converts a UNIX timestamp to a POSIXct
object.
- get.date.string: Converts a POSIXct object to a string representative
of the format "%Y-%m-%d %H:%M:%S".
This heavily improves the patch supplied via PR #85. Thanks to @flx5 for
his work on that.
This fixes #77.
Improved-by: Claus Hunsen <[email protected]>
Signed-off-by: Felix Prasse <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
clhunsen
changed the title
bockthom
approved these changes
Feb 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be more reliable regarding the parsing and printing of dates, we introduce three functions to the misc module, all using the package
lubridateto achieve the task:get.date.from.string: Parses a date string to aPOSIXctobject.get.date.from.unix.timestamp: Converts a UNIX timestamp to aPOSIXctobject.get.date.string: Converts aPOSIXctobject to a string representative of the format"%Y-%m-%d %H:%M:%S".This heavily improves the patch supplied via PR #85. Thanks to @flx5 for his work on that.
This fixes #77.
Additionally, a forgotten
sqldfstatement is updated to be more consistent and reliable.