Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lubridate package for all POSIXct conversions #85

Closed
wants to merge 22 commits into from
Closed

Use lubridate package for all POSIXct conversions #85

wants to merge 22 commits into from

Conversation

flx5
Copy link
Contributor

@flx5 flx5 commented Dec 30, 2017

This pull request adds two methods for parsing dates:

parse.date parses dates, optionally with times using lubridate
timestamp.to.date converts unix timestamps to POSIXCt dates

The calls to as.POSIXct have been replaced with calls to these methods.

This should fix #77

Felix Prasse added 22 commits December 21, 2017 17:10
Add methods required to add vertex attributes to the graph.
Add method to calculate commit count as vertex attribute

Signed-off-by: Felix Prasse <[email protected]>
Signed-off-by: Felix Prasse <[email protected]>
- Rename aggregation to aggregation.level and all to project
- Rename add.vertex.attributes.* methods to add.vertex.attribute.*
- Rename compute.vertex.attribute.with.n2r to add.vertex.attribute
- Rename compute.vertex.attribute to split.and.add.vertex.attribute
- Move networks.to.ranges to util-split and
  rename it to split.data.by.networks
- Remove explicit return statement where possible
- Add missing documentation

Signed-off-by: Felix Prasse <[email protected]>
Signed-off-by: Felix Prasse <[email protected]>
Add test for add.vertex.attribute
Add test for split.and.add.vertex.attribute
Add test for add.vertex.attribute.commit.count
Add test for add.vertex.attribute.author.email
Add test for add.vertex.attribute.artifact.count
Add test for add.vertex.attribute.first.activity

Signed-off-by: Felix Prasse <[email protected]>
The tests were referencing to a wrong project data variable

Signed-off-by: Felix Prasse <[email protected]>
Add test for add.vertex.attribute.author.role.simple
Add test for add.vertex.attribute.active.ranges

Signed-off-by: Felix Prasse <[email protected]>
Add artifact attributes
Add commit count based on committer

Signed-off-by: Felix Prasse <[email protected]>
Create helper method for date parsing parse.date
Create helper method for converting unix timestamps
to date objects timestamp.to.date

Signed-off-by: Felix Prasse <[email protected]>
@flx5 flx5 changed the base branch from master to dev December 30, 2017 16:19
@clhunsen
Copy link
Collaborator

I will review this pull request after PR #67 is finished and this one rebased.

@clhunsen
Copy link
Collaborator

After updating PR #67 in PR #93, we will handle this PR the same way: I will get the patch, rebase it on onto the status of #93, and then open a new PR for this.

Thank you very much for your effort, @flx5.

@clhunsen
Copy link
Collaborator

This PR is closed in favor for its updated version in PR #94.

@clhunsen clhunsen added this to the v3.1 milestone Feb 19, 2018
@clhunsen clhunsen mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants