Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for prometheus_address #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for prometheus_address #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ansible-scylla-node/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ scylla_seeds:
scylla_listen_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}"
scylla_rpc_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}"
scylla_broadcast_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}"
scylla_broadcast_rpc_address: "{{ scylla_rpc_address }}"
scylla_broadcast_rpc_address: "{{ scylla_listen_address if scylla_rpc_address == '0.0.0.0' else scylla_rpc_address }}"
Copy link
Collaborator Author

@tarzanek tarzanek Mar 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prometheus_address might not be needed after SM was fixed re rest api calls
but above line should still be moved to some other PR, since it safeguards a condition from scylla.yaml
perhaps move to #153 as separate commit?

scylla_prometheus_address: "{{ scylla_listen_address }}"

scylla_api_address: '127.0.0.1'
scylla_api_port: '10000'
Expand Down
1 change: 1 addition & 0 deletions ansible-scylla-node/templates/scylla.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ endpoint_snitch: {{ scylla_snitch }}
rpc_address: {{ scylla_rpc_address }}
broadcast_address: {{ scylla_broadcast_address }}
broadcast_rpc_address: {{ scylla_broadcast_rpc_address }}
prometheus_address: {{ scylla_prometheus_address }}
rpc_port: 9160
api_port: {{ scylla_api_port }}
api_address: {{ scylla_api_address }}
Expand Down