add support for prometheus_address #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix condition for setting default broadcast_rpc_address when rpc address is 0.0.0.0
tarzanek
force-pushed
the
prometheus_address
branch
from
c5ccccd
to
cc2c241
Compare
tarzanek
commented
Mar 31, 2023
| @@ -187,7 +187,8 @@ scylla_seeds: | |||
| scylla_listen_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}" | |||
| scylla_rpc_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}" | |||
| scylla_broadcast_address: "{{ vars['ansible_'~scylla_nic].ipv4.address }}" | |||
| scylla_broadcast_rpc_address: "{{ scylla_rpc_address }}" | |||
| scylla_broadcast_rpc_address: "{{ scylla_listen_address if scylla_rpc_address == '0.0.0.0' else scylla_rpc_address }}" | |||
There was a problem hiding this comment.
prometheus_address might not be needed after SM was fixed re rest api calls
but above line should still be moved to some other PR, since it safeguards a condition from scylla.yaml
perhaps move to #153 as separate commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.