Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote datasets #842

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Conversation

berombau
Copy link
Contributor

This is the PR to close #441.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 86.86869% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.01%. Comparing base (4021946) to head (d9e4eac).

Files with missing lines Patch % Lines
src/spatialdata/_io/_utils.py 76.47% 8 Missing ⚠️
src/spatialdata/_io/io_zarr.py 89.18% 4 Missing ⚠️
src/spatialdata/_io/io_raster.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   92.11%   92.01%   -0.10%     
==========================================
  Files          48       48              
  Lines        7429     7468      +39     
==========================================
+ Hits         6843     6872      +29     
- Misses        586      596      +10     
Files with missing lines Coverage Δ
src/spatialdata/_core/spatialdata.py 91.57% <100.00%> (+0.11%) ⬆️
src/spatialdata/_io/io_points.py 100.00% <100.00%> (ø)
src/spatialdata/_io/io_shapes.py 95.08% <100.00%> (-0.08%) ⬇️
src/spatialdata/_io/io_table.py 94.00% <100.00%> (-0.45%) ⬇️
src/spatialdata/_io/io_raster.py 96.12% <90.00%> (-0.73%) ⬇️
src/spatialdata/_io/io_zarr.py 87.82% <89.18%> (-0.64%) ⬇️
src/spatialdata/_io/_utils.py 86.52% <76.47%> (-1.93%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato marked this pull request as ready for review January 31, 2025 09:48
@LucaMarconato LucaMarconato marked this pull request as draft January 31, 2025 14:53
@berombau
Copy link
Contributor Author

berombau commented Feb 1, 2025

I added my progress. Local read/write behavior should still work. Remote reading for raster (image, labels) elements is added. The tests succeeded locally and I expanded the remote tests for future work on reading and writing all elements.

Next steps are:

  • merging with the incremental reading now in main
  • finish the public element read functions
  • merge

Out-of-scope for this PR:

  • support for the remaining points, shapes and tables elements
  • support writing to remote

@LucaMarconato
Copy link
Member

LucaMarconato commented Feb 1, 2025

Thanks @berombau! I will take over for this 😊 (timeline, working on 2-3 PRs and then I want to work on this next).

@berombau berombau closed this Mar 17, 2025
@berombau berombau reopened this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for private remote object storage
3 participants