Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2946 and #3444 #3446

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

keller-mark
Copy link

@keller-mark keller-mark commented Jan 21, 2025

This PR combines the changes from #2946 and #3444

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.51%. Comparing base (6c89e1d) to head (3a904a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/neighbors/_backends/pairwise.py 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
+ Coverage   75.45%   75.51%   +0.06%     
==========================================
  Files         113      115       +2     
  Lines       13243    13292      +49     
==========================================
+ Hits         9992    10037      +45     
- Misses       3251     3255       +4     
Files with missing lines Coverage Δ
src/scanpy/neighbors/__init__.py 80.31% <100.00%> (+0.10%) ⬆️
src/scanpy/neighbors/_types.py 100.00% <100.00%> (ø)
src/scanpy/tools/__init__.py 91.30% <ø> (ø)
src/scanpy/tools/_types.py 100.00% <100.00%> (ø)
src/scanpy/tools/_umap.py 73.52% <100.00%> (+4.17%) ⬆️
src/scanpy/neighbors/_backends/pairwise.py 89.28% <89.28%> (ø)

... and 1 file with indirect coverage changes

@keller-mark
Copy link
Author

rm -rf .venv/

# Run tests with python 3.12 + normal env
export UV_PYTHON="3.12"
uv venv
source .venv/bin/activate
uv sync --extra test

uv run --no-sync pytest tests/test_plotting.py
# This passes

deactivate
rm -rf .venv/

# Run tests with python 3.10 + min-deps env
export UV_PYTHON="3.10"
uv venv
source .venv/bin/activate
uv pip install  --compile scikit-image "dask[array]==2022.9.2.*" zarr "leidenalg==0.9.0.*" "igraph==0.10.*" profimp pytest-cov pytest-mock pytest-nunit "pytest==8.2.*" towncrier pre-commit setuptools_scm typing-extensions "legacy-api-wrap==1.4.*" session-info2 "packaging==21.3.*" "umap-learn==0.5.*"  joblib natsort "networkx==2.7.*" patsy "statsmodels==0.13.*" "scikit-learn==1.1.*" tqdm "h5py==3.7.*" "seaborn==0.13.*" "scipy==1.8.*" "pandas==1.5.*" "matplotlib==3.6.*" "numpy==1.24.*" "anndata==0.8.*" "scanpy @ ."

uv run --no-sync pytest tests/test_plotting.py
# This fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants