Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCA tests #3336

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Fix PCA tests #3336

merged 6 commits into from
Nov 5, 2024

Conversation

flying-sheep
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (dda1f6e) to head (c4a1e0a).
Report is 5 commits behind head on ig/fix_pca_args.

Files with missing lines Patch % Lines
src/scanpy/_utils/__init__.py 83.33% 2 Missing ⚠️
src/scanpy/get/_aggregated.py 75.00% 1 Missing ⚠️
src/scanpy/tools/_draw_graph.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           ig/fix_pca_args    #3336      +/-   ##
===================================================
+ Coverage            77.21%   77.22%   +0.01%     
===================================================
  Files                  111      111              
  Lines                12597    12604       +7     
===================================================
+ Hits                  9727     9734       +7     
  Misses                2870     2870              
Files with missing lines Coverage Δ
src/scanpy/neighbors/__init__.py 81.06% <100.00%> (ø)
src/scanpy/neighbors/_types.py 100.00% <ø> (ø)
src/scanpy/plotting/_anndata.py 85.56% <100.00%> (-0.02%) ⬇️
src/scanpy/preprocessing/_pca/__init__.py 91.91% <100.00%> (+1.10%) ⬆️
src/scanpy/tools/_rank_genes_groups.py 94.50% <100.00%> (-0.02%) ⬇️
src/scanpy/get/_aggregated.py 95.23% <75.00%> (ø)
src/scanpy/tools/_draw_graph.py 65.00% <75.00%> (-0.58%) ⬇️
src/scanpy/_utils/__init__.py 75.51% <83.33%> (-0.01%) ⬇️

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something up with the CI, looks relevant

@flying-sheep flying-sheep changed the title Fix-pca-tests Fix PCA tests Nov 4, 2024
@flying-sheep
Copy link
Member Author

we need to finally fix that CI failure in this job, I only look into the minimum_versions job anymore before I merge PRs

@flying-sheep flying-sheep merged commit 041b3bd into ig/fix_pca_args Nov 5, 2024
11 checks passed
@flying-sheep flying-sheep deleted the fix-pca-tests branch November 5, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants