Skip to content

fix load_slice panic in mock prover err display #207

fix load_slice panic in mock prover err display

fix load_slice panic in mock prover err display #207

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Clippy (1.56.1) failed Jul 4, 2023 in 0s

Clippy (1.56.1)

12 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 12
Warning 0
Note 0
Help 0

Versions

  • rustc 1.63.0 (4b91a6ea7 2022-08-08)
  • cargo 1.63.0 (fd9c4297c 2022-07-01)
  • clippy 0.1.63 (4b91a6e 2022-08-08)

Annotations

Check failure on line 895 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/dev.rs:895:9
    |
895 |         &self.fixed[column.index()]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 891 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/dev.rs:891:9
    |
891 |         &self.advice[column.index()]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 180 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

function `unpack` is never used

error: function `unpack` is never used
   --> halo2_proofs/src/helpers.rs:180:8
    |
180 | pub fn unpack(byte: u8, bits: &mut [bool]) {
    |        ^^^^^^

Check failure on line 170 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

function `pack` is never used

error: function `pack` is never used
   --> halo2_proofs/src/helpers.rs:170:8
    |
170 | pub fn pack(bits: &[bool]) -> u8 {
    |        ^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`

Check failure on line 895 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/dev.rs:895:9
    |
895 |         &self.fixed[column.index()]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 891 in halo2_proofs/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/dev.rs:891:9
    |
891 |         &self.advice[column.index()]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 180 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

function `unpack` is never used

error: function `unpack` is never used
   --> halo2_proofs/src/helpers.rs:180:8
    |
180 | pub fn unpack(byte: u8, bits: &mut [bool]) {
    |        ^^^^^^

Check failure on line 170 in halo2_proofs/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

function `pack` is never used

error: function `pack` is never used
   --> halo2_proofs/src/helpers.rs:170:8
    |
170 | pub fn pack(bits: &[bool]) -> u8 {
    |        ^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`

Check failure on line 576 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `sub_cs`

error: unused variable: `sub_cs`
   --> halo2_proofs/src/plonk/circuit.rs:576:25
    |
576 |     fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> {
    |                         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`

Check failure on line 571 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `ranges`

error: unused variable: `ranges`
   --> halo2_proofs/src/plonk/circuit.rs:571:24
    |
571 |     fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> {
    |                        ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges`
    |
    = note: `-D unused-variables` implied by `-D warnings`

Check failure on line 576 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `sub_cs`

error: unused variable: `sub_cs`
   --> halo2_proofs/src/plonk/circuit.rs:576:25
    |
576 |     fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> {
    |                         ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`

Check failure on line 571 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

unused variable: `ranges`

error: unused variable: `ranges`
   --> halo2_proofs/src/plonk/circuit.rs:571:24
    |
571 |     fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> {
    |                        ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges`
    |
    = note: `-D unused-variables` implied by `-D warnings`