Skip to content

fix load_slice panic in mock prover err display #207

fix load_slice panic in mock prover err display

fix load_slice panic in mock prover err display #207

Triggered via push July 4, 2023 06:07
Status Success
Total duration 3m 3s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

lints-beta.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 22 warnings
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L895
error: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:895:9 | 895 | &self.fixed[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L891
error: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:891:9 | 891 | &self.advice[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
error: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
error: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `-D dead-code` implied by `-D warnings`
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L895
error: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:895:9 | 895 | &self.fixed[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L891
error: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:891:9 | 891 | &self.advice[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
error: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
error: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `-D dead-code` implied by `-D warnings`
unused variable: `sub_cs`: halo2_proofs/src/plonk/circuit.rs#L576
error: unused variable: `sub_cs` --> halo2_proofs/src/plonk/circuit.rs:576:25 | 576 | fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`
unused variable: `ranges`: halo2_proofs/src/plonk/circuit.rs#L571
error: unused variable: `ranges` --> halo2_proofs/src/plonk/circuit.rs:571:24 | 571 | fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges` | = note: `-D unused-variables` implied by `-D warnings`
unused variable: `sub_cs`: halo2_proofs/src/plonk/circuit.rs#L576
error: unused variable: `sub_cs` --> halo2_proofs/src/plonk/circuit.rs:576:25 | 576 | fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`
unused variable: `ranges`: halo2_proofs/src/plonk/circuit.rs#L571
error: unused variable: `ranges` --> halo2_proofs/src/plonk/circuit.rs:571:24 | 571 | fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges` | = note: `-D unused-variables` implied by `-D warnings`
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L674
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:674:5 | 674 | #[test] | ^^^^^^^ | = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L644
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:644:5 | 644 | #[test] | ^^^^^^^ | = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
cannot test inner items: halo2_proofs/tests/plonk_api.rs#L599
warning: cannot test inner items --> halo2_proofs/tests/plonk_api.rs:599:5 | 599 | #[test] | ^^^^^^^ | = note: `#[warn(unnameable_test_items)]` on by default = note: this warning originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
redundant clone: halo2_proofs/tests/plonk_api.rs#L558
warning: redundant clone --> halo2_proofs/tests/plonk_api.rs:558:39 | 558 | &[circuit.clone(), circuit.clone()], | ^^^^^^^^ help: remove this | = note: `-W clippy::redundant-clone` implied by `-W clippy::all` note: this value is dropped without further use --> halo2_proofs/tests/plonk_api.rs:558:32 | 558 | &[circuit.clone(), circuit.clone()], | ^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
function `test_plonk_api_ipa` is never used: halo2_proofs/tests/plonk_api.rs#L675
warning: function `test_plonk_api_ipa` is never used --> halo2_proofs/tests/plonk_api.rs:675:8 | 675 | fn test_plonk_api_ipa() { | ^^^^^^^^^^^^^^^^^^
function `test_plonk_api_shplonk` is never used: halo2_proofs/tests/plonk_api.rs#L645
warning: function `test_plonk_api_shplonk` is never used --> halo2_proofs/tests/plonk_api.rs:645:8 | 645 | fn test_plonk_api_shplonk() { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L895
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:895:9 | 895 | &self.fixed[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L891
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:891:9 | 891 | &self.advice[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]` | = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L895
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:895:9 | 895 | &self.fixed[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.fixed[column.index()]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/src/dev.rs#L891
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/src/dev.rs:891:9 | 891 | &self.advice[column.index()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.advice[column.index()]` | = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
warning: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
warning: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `#[warn(dead_code)]` on by default
function `unpack` is never used: halo2_proofs/src/helpers.rs#L180
warning: function `unpack` is never used --> halo2_proofs/src/helpers.rs:180:8 | 180 | pub fn unpack(byte: u8, bits: &mut [bool]) { | ^^^^^^
function `pack` is never used: halo2_proofs/src/helpers.rs#L170
warning: function `pack` is never used --> halo2_proofs/src/helpers.rs:170:8 | 170 | pub fn pack(bits: &[bool]) -> u8 { | ^^^^ | = note: `#[warn(dead_code)]` on by default
unused variable: `sub_cs`: halo2_proofs/src/plonk/circuit.rs#L576
warning: unused variable: `sub_cs` --> halo2_proofs/src/plonk/circuit.rs:576:25 | 576 | fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`
unused variable: `ranges`: halo2_proofs/src/plonk/circuit.rs#L571
warning: unused variable: `ranges` --> halo2_proofs/src/plonk/circuit.rs:571:24 | 571 | fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges` | = note: `#[warn(unused_variables)]` on by default
unused variable: `sub_cs`: halo2_proofs/src/plonk/circuit.rs#L576
warning: unused variable: `sub_cs` --> halo2_proofs/src/plonk/circuit.rs:576:25 | 576 | fn merge(&mut self, sub_cs: Vec<Self>) -> Result<(), Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_cs`
unused variable: `ranges`: halo2_proofs/src/plonk/circuit.rs#L571
warning: unused variable: `ranges` --> halo2_proofs/src/plonk/circuit.rs:571:24 | 571 | fn fork(&mut self, ranges: &[Range<usize>]) -> Result<Vec<Self>, Error> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ranges` | = note: `#[warn(unused_variables)]` on by default
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/