Disambiguate ShockwaveDamage cases
#6365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baezon
added
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a weapon's shockwave damage has not been specified via table,
ShockwaveDamageshould return -1 instead of 0, and otherwise return the value set via table, allowing scripts to disambiguate explicitly 0 and unspecified. Additionally, a few parsing changes to ensure shockwave damage can never genuinely be negative (all damage handling is already doing this so this will have no gameplay effects).This is an explicit, unflagged change to the specification of this script value, but it's really not worth a flag, and a very niche case for which backwards compatibility concerns would surely be negligible.