Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pre-movie hook #6332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add pre-movie hook #6332

wants to merge 2 commits into from

Conversation

Goober5000
Copy link
Contributor

Add an $On Movie About To Play: hook to match $On Intro About To Play:. Also make the two hooks overridable, since that might be useful.

Additionally, change a few (nonexhaustive) name parameters to filename to make it clearer that the string is a filename.

@Goober5000 Goober5000 added enhancement A new feature or upgrade of an existing feature to add additional functionality. scripting A feature or issue related to LUA scripting Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle Requested by Active Mod A feature request that has been requested by a mod that is actively in development. labels Aug 29, 2024
@Goober5000 Goober5000 force-pushed the movie_hooks branch 3 times, most recently from 7c487d3 to 50ce85e Compare September 4, 2024 03:04
@Goober5000
add pre-movie hook
3d8fbc0 
Add an `$On Movie About To Play:` hook to match `$On Intro About To Play:`.  Also make the two hooks overridable, since that might be useful.

Additionally, change a few (nonexhaustive) `name` parameters to `filename` to make it clearer that the string is a filename.
@Goober5000
remove redundant cutscene_mark_viewable()
66bf2ae 
This is already done in `movie::play()` and shouldn't be done again if a script overrides the function.  The extra calls were added in 251285c and cbccf65 (the former copied from the latter), originally as an unsuccessful attempt to fix Mantis 61.
wookieejedi
wookieejedi approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly could be useful and looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookieejedi wookieejedi wookieejedi approved these changes

Assignees
No one assigned
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality. Requested by Active Mod A feature request that has been requested by a mod that is actively in development. scripting A feature or issue related to LUA scripting Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goober5000 @wookieejedi