Check a pull request

Fix deferred lighting Option #4638

Triggered via pull request September 9, 2024 19:41

BMagnu

opened #6346

BMagnu:fix_deferred_toggle

Status Failure

Total duration 20m 19s

Artifacts –

test-pull_request.yaml

on: pull_request

Matrix: Linux

Matrix: Mac

Matrix: Windows

Annotations

5 errors and 18 warnings

Linux (Release, clang-16): code/options/Option.h#L574

clang-tidy: return type 'const std::shared_ptr<Option<T>>' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness (readability-const-return-type)

Linux (Release, clang-16): code/options/OptionsManager.cpp#L109

clang-tidy: the parameter 'option' is copied for each invocation but only used as a const reference; consider making it a const reference (performance-unnecessary-value-param)

Linux (Release, clang-16)

Found 2 clang-tidy issues

Linux (Debug, clang-16)

The job was canceled because "Release_clang-16" failed.

Linux (Debug, clang-16)

The operation was canceled.

Mac (Release, clang, x86_64)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Mac (Release, clang, x86_64)

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Mac (Debug, clang, x86_64)