Optimizations #275
Merged
Optimizations #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you |
|
thanks so much for reviewing / merging the big one that needs work is consumeToAny. the unicode scalar vs utf8/utf16 indexing is half of it (and maybe the need to make strings utf8 contiguous, I didn't verify), the other is instantiating the new string. maybe it can be reworked to use substrings. I read through the source but couldn't confidently decide what to try |
aehlke
commented
Aug 2, 2024
| @@ -417,7 +422,7 @@ enum TokeniserState: TokeniserStateProtocol { | |||
| t.emit(TokeniserStateVars.replacementChar) | |||
| break | |||
| default: | |||
| let data = r.consumeToAny("-", UnicodeScalar.LessThan, TokeniserStateVars.nullScalr) | |||
| let data = r.consumeToAny(TokeniserStateVars.dataDefaultStopChars) | |||
There was a problem hiding this comment.
this and next change were my errors
aehlke
added a commit
to lake-of-fire/SwiftSoup
that referenced
this pull request
Aug 2, 2024
aehlke
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.