UTF-8 view optimizations + Regression fix for #275 #276
Conversation
|
Room for improvement, but it seems MUCH faster now that it operates on utf8view and utf8 indexes |
| @@ -1,263 +1,187 @@ | |||
| // | |||
There was a problem hiding this comment.
oops not intentional to remove this part
aehlke
changed the title
|
Sorry for entangling the improvement from the regression fix, but that can be fixed / the regression changes can be extracted from it I need to do more profiling again and find more room for improvement, but I believe this change to utf8view is a massive improvement to SwiftSoup speed. So I hope we can get this merged too. I think the next biggest win would likely be to change all functions from operating on String to operating on a view or slice (I forget the correct type names for this) that reflects string data from the source without needing to ever copy that data or rarely, or even arrays of them as needed, which can be turned into string at a price and at the library user's choice. But maybe this doesn't matter as much if this utf8 change is complete (not sure it does this yet actually) enough to have String copying be fast now because of copying byte data |
|
@scinfu may I suggest you add more maintainers to the project to be able to review/merge issues with less trouble :) |
|
@aehlke yes, good idea. |
|
@aehlke Could you please add a test to prevent this bug in the future? |
|
@scinfu I added testing for the hang (by adding a timeout waiter) which repros without my fix in this PR. I also fixed the test suite (unrelated broken test) I will merge once tests pass as a hotfix |
|
Ignoring the 5.7 failure, all other tests passed 5.7 failure issue tracked here: #282 It's unrelated, an apparently recent Xcode 15 regression |
I haven't benchmarked yet, but in theory this should be faster
Haven't fully tested yet either
Note that this increases the minimum platform versions