Add more tests #79
Merged
Add more tests #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
more-tests
branch
2 times, most recently
from
928a6f2 to
e35a06b
Compare
|
Thanks @jayvdb, this is testing and working for me locally, so I'm going to merge as is. One orthogonal thing to this PR is that I noticed the tests use some groupId:artifactId endpoints with no version specified. It would be best to lock in the versions of these Java components, so that tests stay reproducible as time goes on. I will file a separate issue for this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #44
This takes the coverage from 69% to slightly over 90%.
Many of the tests are using unrealistic arg combinations for various endpoints. More than happy to adjust them to use more realistic scenarios.