Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write some tests #44

Closed
ctrueden opened this issue Jun 28, 2019 · 3 comments
Closed

Write some tests #44

ctrueden opened this issue Jun 28, 2019 · 3 comments
Assignees
Milestone

Comments

@ctrueden
Copy link
Member

We can use cram. For all tests, run with both versions of jgo.

  • Execute Parsington 1+3
  • Shortcuts
  • Main class abbreviations with @
  • FQCN main class
  • No main class
  • Repeated execution of same endpoint
  • Consistency of cache directory trees
  • Various flags (-u, -U, -m, -v)
@ctrueden ctrueden added this to the 1.0.0 milestone Jun 28, 2019
@jayvdb
Copy link
Contributor

jayvdb commented Jul 26, 2022

I am writing some tests atm, and would love to know a real use case for --additional-endpoints and --additional-jars.

I noticed an issue where an additional jar was needed for Groovy, but it seems to not need it now as PATH=/c/Program\ Files/Java/jdk-17.0.2/bin/:$PATH jgo org.codehaus.groovy:groovy-groovysh:org.codehaus.groovy.tools.shell.Main drops me into a Groovy prompt.

I see #43 deprecated --additional-jars three (3) years ago - I could just remove that CLI arg so it doesn't need tests.

@jayvdb jayvdb mentioned this issue Jul 31, 2022
@jayvdb
Copy link
Contributor

jayvdb commented Aug 1, 2022

The main set of code not covered in #79 was the if main_class[0] == "@": branch in autocomplete_main_class. I couldnt quickly see how to trigger that.

@ctrueden ctrueden modified the milestones: 1.0.0, unscheduled, 1.0.5 Nov 15, 2022
@ctrueden
Copy link
Member Author

I filed #86 to track the test reproducibility issue with unpinned versions. I am closing this issue, thanks to @jayvdb's nice work on #79. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants