Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when reading a Scala 2 macro definition. #420

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Do not crash when reading a Scala 2 macro definition. #420

merged 2 commits into from
Dec 18, 2023

Commits on Dec 14, 2023

  1. Do not crash when reading a Scala 2 macro definition. 

    It contains an annotation with a subtree that is an `IDENTtree`
without prefix nor symbol, with the name `macro`. That is then
`Apply`ed and `TypeApply`ed in ways that make no semantic sense.

We define a special symbol in `Definitions`, which we attach to
such fake identifiers.
    @sjrd
    sjrd committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1a83796 View commit details
    Browse the repository at this point in the history

  2. Add a Scala 2 test sources project, and test Scala 2 macro reading.

    @sjrd
    sjrd committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    19b3b2e View commit details
    Browse the repository at this point in the history