Do not crash when reading a Scala 2 macro definition.
#420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
reviewed
Dec 12, 2023
|
Only for things that we can find in the standard library. We don't have a setup for other weird stuff that we only find elsewhere, unfortunately. |
|
What about adding a Scala 2 test project like this one? |
sjrd
force-pushed
the
no-crash-on-scala2-macro-info-annot
branch
from
253434a
to
12152c4
Compare
It contains an annotation with a subtree that is an `IDENTtree` without prefix nor symbol, with the name `macro`. That is then `Apply`ed and `TypeApply`ed in ways that make no semantic sense. We define a special symbol in `Definitions`, which we attach to such fake identifiers.
sjrd
force-pushed
the
no-crash-on-scala2-macro-info-annot
branch
from
12152c4
to
1a83796
Compare
|
All right, I added a |
adpi2
approved these changes
Dec 18, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains an annotation with a subtree that is an
IDENTtreewithout prefix nor symbol, with the namemacro. That is thenApplyed andTypeApplyed in ways that make no semantic sense.We define a special symbol in
Definitions, which we attach to such fake identifiers.