SbomExtractor improvements #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Dec 6, 2024
lhns
force-pushed
the
feature/bom-extractor-updates
branch
from
900959f to
b1dad9c
Compare
raboof
approved these changes
Dec 9, 2024
|
oh no why are the hashes different in ci... |
|
ohh they are selected based on the java version in org.cyclonedx.util.BomUtils: try {
digests.add(DigestUtils.getSha3_256Digest());
} catch (Exception | NoSuchMethodError e) { /* Not available in Java 8 and only available in later versions of DigestUtils */ } |
raboof
reviewed
Dec 10, 2024
| includeBomTimestamp := false, | ||
| includeBomToolVersion := true, | ||
| includeBomHashes := true, | ||
| enableBomSha3Hashes := true, |
There was a problem hiding this comment.
I wonder if we should default this to false, to be more reproducible by default...
There was a problem hiding this comment.
I also thought about this but java 8 is mostly end of life anyway and the sha3 family will be pretty important in the future and should probably be enabled by default sooner than later. The gradle cyclonedx plugin also does not filter out hashes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following attributes to sboms:
It also fixes an error caused by modules that are reported multiple times (cross builds, complex dependsOn structure and such)