Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json bomFormat #99

Merged
merged 7 commits into from
Dec 12, 2024
Merged

json bomFormat #99

merged 7 commits into from
Dec 12, 2024

Conversation

lhns
Copy link
Contributor

@lhns lhns commented Dec 11, 2024

I've added a configurable bomFormat with json support.
Should json be new default format? I saw that some tooling is using it as the new default.
fixes #91

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I suppose longer-term we might want to restructure the commands structure so you can more easily generate (and publish) xml, json or both, but that can be a separate activity - this is already great. I don't have a strong preference for the defaults here.

src/sbt-test/dependencies/integrationTest/etc/bom.xml Outdated Show resolved Hide resolved
lhns added 2 commits December 12, 2024 10:14
…n-bom

# Conflicts:
#	README.md
#	src/main/scala/com/github/sbt/sbom/BomExtractor.scala
#	src/main/scala/com/github/sbt/sbom/BomSbtSettings.scala
#	src/sbt-test/dependencies/integrationTest/etc/bom.xml
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

src/sbt-test/dependenciesJson/compile/build.sbt Outdated Show resolved Hide resolved
@raboof raboof merged commit 16d8b33 into sbt:main Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support producing CycloneDX JSON
2 participants