Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix as many small bugs as i can #363

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix as many small bugs as i can #363

merged 4 commits into from
Apr 11, 2024

Conversation

sblunt
Copy link
Owner

@sblunt sblunt commented Feb 29, 2024

Fixing as many "easy" bugs as I can in the next 24 hours challenge!

So far, the list includes:

@sblunt sblunt mentioned this pull request Feb 29, 2024
Closed
@sblunt
Copy link
Owner Author

sblunt commented Mar 18, 2024

@sblunt sblunt mentioned this pull request Mar 18, 2024
Closed
@sblunt sblunt mentioned this pull request Mar 18, 2024
Closed
@sblunt sblunt requested a review from semaphoreP March 18, 2024 22:10
@sblunt
Copy link
Owner Author

sblunt commented Mar 18, 2024

  • add Raised Error when using RV data #351: orbitize! was at some point throwing an error when setting fit_secondary_mass=False and including companion RVs. I actually couldn't reproduce this bug anymore, but I added a unit test to check that this stays fixed in the future.

@semaphoreP semaphoreP self-assigned this Mar 28, 2024
semaphoreP
semaphoreP approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@semaphoreP semaphoreP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@semaphoreP semaphoreP merged commit c1ad5f0 into v3 Apr 11, 2024
8 checks passed
@semaphoreP semaphoreP deleted the fix-as-many-small-bugs-as-i-can branch April 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semaphoreP semaphoreP semaphoreP approved these changes

Assignees

@semaphoreP semaphoreP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sblunt @semaphoreP