Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised Error when using RV data #351

Closed
juague135 opened this issue Dec 15, 2023 · 2 comments
Closed

Raised Error when using RV data #351

juague135 opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@juague135
Copy link

Orbitize raises an exception when attempting to use a dataset with RV data. "Exception: If including RV data in orbit fit, set fit_secondary_mass=True"

@semaphoreP
Copy link
Collaborator

Note that this is the case of only planetary RV

@sblunt sblunt added the bug Something isn't working label Jan 23, 2024
@sblunt sblunt self-assigned this Feb 27, 2024
sblunt added a commit that referenced this issue Mar 18, 2024
@sblunt
Copy link
Owner

sblunt commented Mar 18, 2024

Hey Juan, finally getting around to addressing this bug! I think in the meantime, I must have fixed this somewhere along the line, because I can't reproduce it any more. I was fiddling with the companion rv implementation a lot around this time, so I'm sure it's buried somewhere in all the commit messages. I added a unit test to check this scenario and make sure it stays fixed in the future (in #363). Please reopen if you run into this issue again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants