-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-form-field): introduce size s #2995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeripeierSBB
added
the
pr: ux review required
A ux review is required for this pull request
label
Aug 8, 2024
github-actions
bot
added
the
pr: peer review required
A peer review is required for this pull request
label
Aug 8, 2024
28 tasks
DavideMininni-Fincons
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, finger crossed for @mcilurzo approval :D
github-actions
bot
added
pr: peer review approved
Pull request has been approved by a peer review
and removed
pr: peer review required
A peer review is required for this pull request
labels
Aug 8, 2024
# Conflicts: # src/visual-regression-app/src/components/test-case/image-diff/fullscreen-diff/fullscreen-diff.scss
mcilurzo
added
pr: ux review approved
Pull request has been approved by a ux review
and removed
pr: ux review required
A ux review is required for this pull request
labels
Aug 14, 2024
Looks good to me. thank you @DavideMininni-Fincons and @jeripeierSBB |
mcilurzo
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
diff-available
pr: peer review approved
Pull request has been approved by a peer review
pr: ux review approved
Pull request has been approved by a ux review
pr: visual review required
preview-available
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2545
Closes #2764
Replaces #2610