Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-form-field): introduce size s #2995

Merged
merged 8 commits into from
Aug 14, 2024
Merged

feat(sbb-form-field): introduce size s #2995

merged 8 commits into from
Aug 14, 2024

Conversation

jeripeierSBB
Copy link
Contributor

Closes #2545
Closes #2764
Replaces #2610

@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Aug 8, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 8, 2024
@jeripeierSBB jeripeierSBB mentioned this pull request Aug 8, 2024
28 tasks
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, finger crossed for @mcilurzo approval :D

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Aug 8, 2024
@github-actions github-actions bot temporarily deployed to pr2995 August 8, 2024 14:31 Inactive
@github-actions github-actions bot temporarily deployed to pr2995-diff August 8, 2024 14:32 Inactive
@mcilurzo
Copy link
Contributor

mcilurzo commented Aug 9, 2024

@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Aug 14, 2024
@mcilurzo
Copy link
Contributor

Looks good to me. thank you @DavideMininni-Fincons and @jeripeierSBB

@jeripeierSBB jeripeierSBB merged commit 9abb131 into main Aug 14, 2024
22 of 23 checks passed
@jeripeierSBB jeripeierSBB deleted the form-field-size-s branch August 14, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textarea: Size S Form-Field: Size S
3 participants