Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-form-field): add size s #2610

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Apr 23, 2024

Preflight Checklist

Issue

This PR Closes #2545

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • sbb-form-field accept 's' as size value

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Apr 23, 2024 that may be closed by this pull request
@DavideMininni-Fincons DavideMininni-Fincons marked this pull request as ready for review April 23, 2024 08:31
@github-actions github-actions bot temporarily deployed to preview-pr2610 April 23, 2024 08:41 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2610 April 23, 2024 09:20 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (e6397df) to head (6788287).
Report is 75 commits behind head on main.

❗ Current head 6788287 differs from pull request most recent head 7f4f4c9. Consider uploading reports for the commit 7f4f4c9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   93.18%   93.19%           
=======================================
  Files         316      316           
  Lines       25389    25403   +14     
  Branches     2063     2063           
=======================================
+ Hits        23660    23674   +14     
  Misses       1696     1696           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…size-s

# Conflicts:
#	src/components/form-field/form-field/form-field.scss
@github-actions github-actions bot temporarily deployed to preview-pr2610 May 9, 2024 08:38 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2610 May 9, 2024 09:44 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-form-field): add size s [WIP] feat(sbb-form-field): add size s May 13, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 13, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2610 May 13, 2024 09:18 Inactive
…size-s

# Conflicts:
#	src/components/form-field/form-field/readme.md
@DavideMininni-Fincons DavideMininni-Fincons added pr: lead review required A lead review is required for this pull request pr: ux review required A ux review is required for this pull request labels May 14, 2024
@github-actions github-actions bot temporarily deployed to pr2610 May 23, 2024 13:33 Inactive
@github-actions github-actions bot temporarily deployed to pr2610 May 24, 2024 10:03 Inactive
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: blocked Pull request is blocked either for merging or reviewing pr: lead review required A lead review is required for this pull request pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form-Field: Size S
4 participants