Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-flip-card): first implementation #2946

Merged
merged 26 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a0880c4
feat: generate components and folder structure
dauriamarco Jul 9, 2024
88b235f
fix: card details export
dauriamarco Jul 9, 2024
933aaf0
fix: stories
dauriamarco Jul 9, 2024
2152b5a
feat: partial implementation
MarioCastigliano Jul 10, 2024
b785692
fix: image placement
MarioCastigliano Jul 10, 2024
8bcd98f
feat: flip card layout and toggle
dauriamarco Jul 11, 2024
c73679c
feat: flip card logic and focus
dauriamarco Jul 11, 2024
0172aa4
feat: add flip-card stories
dauriamarco Jul 15, 2024
712b84e
fix: flip-card stories
dauriamarco Jul 15, 2024
70a5b23
docs: create documentation
MarioCastigliano Jul 17, 2024
a054d19
fix: use right background color
MarioCastigliano Jul 17, 2024
0285609
test: first part
MarioCastigliano Jul 17, 2024
a40ea4c
feat: stories
MarioCastigliano Jul 17, 2024
e34275e
test: add ssr
MarioCastigliano Jul 17, 2024
4d72c97
test: second part
MarioCastigliano Jul 17, 2024
2f4d982
test: third part
MarioCastigliano Jul 17, 2024
3749b0b
test: add visual spec
MarioCastigliano Jul 17, 2024
22c63a3
feat: localize aria-label
MarioCastigliano Jul 18, 2024
2208e4d
fix: tests
MarioCastigliano Jul 18, 2024
fcc428b
feat: add multiline story
dauriamarco Jul 18, 2024
3a0659f
fix: add visual test cases
MarioCastigliano Jul 18, 2024
8741cb4
fix: review comments
MarioCastigliano Jul 18, 2024
6f981f5
fix: address review comments
MarioCastigliano Jul 18, 2024
8b0a09c
fix: address graphical review
MarioCastigliano Jul 19, 2024
bd1f93b
fix: tests
MarioCastigliano Jul 19, 2024
84273b7
fix: improve data attribute usage
MarioCastigliano Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

:host {
--sbb-flip-card-details-opacity: 0;
--sbb-flip-card-details-translate-y: var(--sbb-spacing-fixed-4x);
--sbb-flip-card-details-translate-y: var(--sbb-spacing-fixed-2x);

display: contents;
}
Expand All @@ -19,5 +19,7 @@
var(--sbb-spacing-responsive-s) + var(--sbb-spacing-responsive-xs) + var(--sbb-size-element-m)
);
transform: translateY(var(--sbb-flip-card-details-translate-y));
transition: all 250ms ease-out;
transition: var(--sbb-flip-card-details-transition-duration) ease-out;
transition-delay: var(--sbb-flip-card-details-transition-delay);
max-height: var(--sbb-flip-card-details-min-height);
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
grid-template-rows: auto 1fr;
width: 100%;
height: 100%;
transition: all 250ms ease-out;
transition: all var(--sbb-flip-card-summary-transition-duration) ease-out;
transition-delay: var(--sbb-flip-card-summary-transition-delay);

:host([image-alignment='after']) & {
@include sbb.mq($from: small) {
Expand Down Expand Up @@ -54,6 +55,7 @@
}

.sbb-flip-card-summary--image-wrapper {
max-height: var(--sbb-flip-card-min-height);
grid-area: 2 / 1 / 3 / 2;

:host([image-alignment='after']) & {
Expand Down
13 changes: 12 additions & 1 deletion src/elements/flip-card/flip-card-summary/flip-card-summary.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { CSSResultGroup, TemplateResult } from 'lit';
import type { CSSResultGroup, PropertyValues, TemplateResult } from 'lit';
import { html, LitElement } from 'lit';
import { customElement, property } from 'lit/decorators.js';

Expand All @@ -25,6 +25,17 @@ export class SbbFlipCardSummaryElement extends LitElement {
@property({ attribute: 'image-alignment', reflect: true })
public imageAlignment: SbbFlipCardImageAlignment = 'after';

protected override willUpdate(_changedProperties: PropertyValues): void {
super.willUpdate(_changedProperties);

if (_changedProperties.has('imageAlignment')) {
this.closest?.('sbb-flip-card')?.toggleAttribute(
'data-image-after',
MarioCastigliano marked this conversation as resolved.
Show resolved Hide resolved
this.imageAlignment === 'after',
);
}
}

protected override render(): TemplateResult {
return html`
<div class="sbb-flip-card-summary">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ snapshots["A11y tree Chrome"] =
/* end snapshot A11y tree Chrome */

snapshots["sbb-flip-card DOM"] =
`<sbb-flip-card>
`<sbb-flip-card data-image-after="">
<sbb-flip-card-summary
image-alignment="after"
slot="summary"
Expand Down Expand Up @@ -91,7 +91,7 @@ snapshots["sbb-flip-card Shadow DOM"] =
dir="ltr"
icon-name="plus-small"
role="button"
size="l"
size="s"
tabindex="0"
>
</sbb-secondary-button>
Expand Down
36 changes: 33 additions & 3 deletions src/elements/flip-card/flip-card/flip-card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,35 @@
// Box-sizing rules contained in typography are not traversing Shadow DOM boundaries. We need to include box-sizing mixin in every component.
@include sbb.box-sizing;

// TODO: improve component's animation
:host {
--sbb-flip-card-background-color: var(--sbb-color-cloud-alpha-80);
--sbb-flip-card-background-color: var(--sbb-color-cloud);
--sbb-flip-card-border-radius: var(--sbb-border-radius-4x);
--sbb-flip-card-min-height: #{sbb.px-to-rem-build(280)};
--sbb-flip-card-details-min-height: var(--sbb-flip-card-min-height);
--sbb-flip-card-summary-transition-duration: var(--sbb-animation-duration-5x);
--sbb-flip-card-summary-transition-delay: var(--sbb-animation-duration-2x);
--sbb-flip-card-details-transition-duration: var(--sbb-animation-duration-4x);
--sbb-flip-card-details-transition-delay: var(--sbb-disable-animation-zero-time);

position: relative;
display: block;

@include sbb.mq($from: medium) {
--sbb-flip-card-min-height: #{sbb.px-to-rem-build(320)};
}
}

:host(:hover) {
--sbb-flip-card-background-color: var(--sbb-color-cloud-alpha-80);
}

:host([data-flipped]) {
--sbb-flip-card-background-color: var(--sbb-color-midnight);
--sbb-flip-card-details-transition-duration: var(--sbb-animation-duration-2x);
--sbb-flip-card-details-transition-delay: var(--sbb-animation-duration-5x);
--sbb-flip-card-summary-transition-delay: var(--sbb-disable-animation-zero-time);
--sbb-flip-card-details-min-height: fit-content;

::slotted(sbb-flip-card-summary) {
--sbb-flip-card-summary-opacity: 0;
Expand All @@ -25,17 +44,28 @@
}
}

:host([data-image-after]) {
@include sbb.mq($from: small, $to: medium) {
--sbb-flip-card-min-height: #{sbb.px-to-rem-build(240)};
}

@include sbb.mq($from: wide) {
--sbb-flip-card-min-height: #{sbb.px-to-rem-build(400)};
}
}

.sbb-flip-card {
position: relative;
display: flex;
height: 100%;
flex-flow: wrap;
MarioCastigliano marked this conversation as resolved.
Show resolved Hide resolved
flex-direction: column;
gap: var(--sbb-spacing-responsive-xs);
min-height: #{sbb.px-to-rem-build(280)}; // TODO: check if correct
min-height: var(--sbb-flip-card-min-height);
background-color: var(--sbb-flip-card-background-color);
border-radius: var(--sbb-flip-card-border-radius);
transition: all 250ms ease-out;
transition: var(--sbb-flip-card-summary-transition-duration) ease-out;
transition-delay: var(--sbb-flip-card-summary-transition-delay);
}

.sbb-flip-card--toggle-button {
Expand Down
13 changes: 6 additions & 7 deletions src/elements/flip-card/flip-card/flip-card.stories.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
import { withActions } from '@storybook/addon-actions/decorator';
import type { InputType } from '@storybook/types';
import type { Args, ArgTypes, Decorator, Meta, StoryObj } from '@storybook/web-components';
import type { Args, ArgTypes, Meta, StoryObj } from '@storybook/web-components';
import type { TemplateResult } from 'lit';
import { html, nothing } from 'lit';

import sampleImages from '../../core/images.js';

import readme from './readme.md?raw';

import './flip-card.js';
import '../flip-card-summary.js';
import '../flip-card-details.js';
import '../../image/image.js';
import '../../title/title.js';
import '../../link/link/link.js';
import '../../title/title.js';
import '../flip-card-details.js';
import '../flip-card-summary.js';
import './flip-card.js';

const imageAlignment: InputType = {
control: {
Expand Down Expand Up @@ -130,7 +129,7 @@ export const LongTitle: StoryObj = {
};

const meta: Meta = {
decorators: [withActions as Decorator],
decorators: [(story) => html`<div style="max-width: 792px;">${story()}</div>`],
parameters: {
docs: {
extractComponentDescription: () => readme,
Expand Down
1 change: 1 addition & 0 deletions src/elements/flip-card/flip-card/flip-card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export class SbbFlipCardElement extends SbbHydrationMixin(LitElement) {
class="sbb-flip-card--toggle-button"
icon-name=${this._flipped ? 'cross-small' : 'plus-small'}
@click=${() => this.toggle()}
size="s"
></sbb-secondary-button>
</div>
`;
Expand Down
Loading