Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-flip-card): first implementation #2946

Merged
merged 26 commits into from
Jul 19, 2024
Merged

Conversation

MarioCastigliano
Copy link
Contributor

@MarioCastigliano MarioCastigliano commented Jul 18, 2024

Preflight Checklist

Issue

This PR Closes #2669

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • sbb-flip-card has been implemented
  • sbb-flip-card-summary has been implemented
  • sbb-flip-card-details has been implemented

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 18, 2024
@github-actions github-actions bot temporarily deployed to pr2946 July 18, 2024 08:23 Inactive
@github-actions github-actions bot temporarily deployed to pr2946-diff July 18, 2024 08:23 Inactive
@github-actions github-actions bot temporarily deployed to pr2946-diff July 18, 2024 14:24 Inactive
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the two suggestions should solve the height issue.
The animation for this might not be perfect yet, but apparently there is still a discussion ongoing on how this should look anyway.

@florianstuerzinger
Copy link

florianstuerzinger commented Jul 19, 2024

Animation does not yet meet the requirements:

Compared to the specification for the animation (https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?node-id=39138-765544&t=iU5yxm8WRYiYnQdz-4), there are still various deviations. Please ensure the following:

Duration: Please ensure that duration and easing correspond to the specifications.

Title: The opacity of the title should fade to 0% when the card is clicked. So that the content and title do not overlap visually.
Content: The text is initially too far down. The movement should only be 8px.
Content: The text starts with an opacity of 0%
Background: The dark background starts in the position and size of the button and extends over the entire width and height when the card is clicked.
Cover: The hover effect is missing

Extra: Is it possible to animate between the icons on the button?

@florianstuerzinger
Copy link

Button size S instead of L

@florianstuerzinger
Copy link

Minimum height and above all independent of the content of the open state.

Zero-Micro:

  • After, min-height 280px
  • Below, min-height 280px

Small:

  • After, min-height 240px
  • Below, min-height 280px

Medium-Large:

  • After, min-height 320px
  • Below, min-height 320px

Wide-Ultra:

  • After, min-height 400px
  • Below, min-height 320px

@kyubisation
Copy link
Contributor

@florianstuerzinger Just a heads-up; The animation will not be perfect yet, but we will continue working on it and can fix that at a later date.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 19, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks again! 😃

@github-actions github-actions bot requested a deployment to pr2946 July 19, 2024 15:59 In progress
@github-actions github-actions bot requested a deployment to pr2946-diff July 19, 2024 15:59 In progress
@MarioCastigliano MarioCastigliano merged commit b086612 into main Jul 19, 2024
33 of 34 checks passed
@MarioCastigliano MarioCastigliano deleted the feat/flip-card branch July 19, 2024 16:00
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story(flip-card): initial implementation (previously Facts-Card)
5 participants