scipy bandaid #106
Merged
scipy bandaid #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupek2
approved these changes
Jan 9, 2025
|
@tupek2 @btalamini any idea why the metis dlls can't be found? |
|
No, but its possible that metis is only used in 1 place, and not really necessary. I had put it in thinking it would be harmless (I was using for a research capability). |
|
Yeah, it's only used in test_PatchTestPou.py. Would it make sense to remove those tests or are they important? |
|
You can remove it. |
cmhamel
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 62 62
Lines 5225 5225
=======================================
Hits 4033 4033
Misses 1192 1192 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes scipy to version 1.14.1 while we sort out issues with newer versions