Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage fixes #2417

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Homepage fixes #2417

merged 10 commits into from
Jan 21, 2025

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Jan 16, 2025

Fixes notch8/palni_palci_knapsack#142

Fixes homepage footer & dropdown menus

  • Homepage dropdown menus now use site's link colors.
  • Footer now includes both login and log off options to avoid need to override footer.
  • Footer now includes option to add a Privacy Policy link via new (empty) menu partial.
Screenshots

Screenshot 2025-01-14 at 7 34 28 PM

Screenshot 2025-01-14 at 7 35 33 PM

Fixes neutral repository homepage

  • Collections section now has a border
  • Adjusts spacing between sections
  • Makes headings consistent
Screenshot

Screenshot 2025-01-15 at 7 21 43 PM

Fixes cultural repository homepage

  • Recent works section is responsive
Screenshot

Screenshot 2025-01-21 at 11 57 46 AM
Screenshot 2025-01-21 at 11 57 57 AM

Fixes institutional repository homepage

  • Footer is fixed.
    Note: Carousel issue is moved to a separate ticket.
Screenshot

Screenshot 2025-01-21 at 12 33 10 PM

@laritakr laritakr marked this pull request as draft January 16, 2025 00:16
@laritakr laritakr added the patch-ver for release notes label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 30s ⏱️ -13s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 7207498. ± Comparison against base commit 9297162.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b575ca18-6286-4d07-a48d-2ad0108db9b2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d831c947-733e-44c3-94bf-9a15066b1625
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 978f64e1-0a0a-4302-ab61-642282a0d5b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b549b05d-9aa8-4016-a956-cdb7d244962d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy cb73e0f2-329b-4e88-be1d-d4b8ac424848
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 49418c7f-3c66-4b69-9b92-f19d03fd8fd6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 2db58287-9e25-478b-b74e-5db96c5975e8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ff820cca-36d3-461a-b607-7d827efc36ff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 42a6f019-9d2e-4d9d-ac03-dd785b26d7be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 424238fe-dadc-4f70-afc1-db66f9295ebc
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 687d79a1-5171-4cdc-845f-77dbafcad006
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 546aa543-70a5-4838-a62e-4f1af6e05928
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 2de7363b-6b30-47d5-ad28-894c7c714ace
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 46029168-340b-4f4c-8b39-cda875bff839
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a7c60420-b943-45c9-a2d8-d3e47b3fbc60
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f9240fb6-f0d1-4c8b-8a6c-722a954730ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ca5767f1-2aa6-4a94-915a-a1620bfa6054
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update a983a72f-8aec-4c4f-83b6-c9d01afb3ea9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 00f5b446-daaa-449e-ae5d-977996717d9e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 24b3d363-489c-4e31-a000-a2dfe0ed9373
…

♻️ This comment has been updated with latest results.

@laritakr laritakr marked this pull request as ready for review January 21, 2025 17:02
@laritakr laritakr merged commit 6b6539f into main Jan 21, 2025
8 checks passed
@laritakr laritakr deleted the homepage-fixes branch January 21, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Themes
2 participants