-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content blocks #2423
Merged
Merged
Fix content blocks #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files ±0 3 suites ±0 17m 50s ⏱️ -3s Results for commit 11bd59b. ± Comparison against base commit 984c237. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Removes duplicated tabs. Adds appropriate classes. Adds missing translations.
kirkkwang
reviewed
Jan 22, 2025
kirkkwang
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
The spec mistakenly used the wrong count expectation, due to duplicate content block form tabs which are now removed.
kirkkwang
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
#2417
notch8/palni_palci_knapsack#172
Restore text color in dropdown menus: fix got lost during a merge conflict patch.
Restore facet border color but in the right location (removed #2420 due to double border)
Fixes appearance of content blocks form by removing duplicate tabs, adding appropriate classes, and adding translations.
Screenshots
Dropdown menu text now matches link text color
Facet border color once again based on a darker version of facet background color rather than bootstrap default
An exception is the cultural theme
Fixes content blocks form