Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telling VSCode that Prettier is the default formatter #67

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

khawkins
Copy link
Collaborator

Just helps keep VSCode formatting synced up with what we align to in our Node project.

@khawkins khawkins requested a review from a team as a code owner June 24, 2024 19:09
@khawkins
Copy link
Collaborator Author

The test failures are a bit of an unwinding, here. I went looking for the cause of this error:

Failed to run tests Error: spawnSync D:\a\salesforcedx-vscode-mobile\salesforcedx-vscode-mobile.vscode-test\vscode-win32-x64-archive-1.90.2\bin\code.cmd EINVAL

which looked to be fixed by microsoft/vscode-test-cli#46, except vscode-test-cli is new news to me. Went to Microsoft's docs on testing your extension, and it looks like they've quietly rolled out a new Node package to assist in the previous setup.

Going to see what it takes to change our test runner accordingly.

@khawkins
Copy link
Collaborator Author

NB: Didn't need to change our test runner over to the other package—and couldn't anyway, because (AFAICT) the need to install the Salesforce Extensions pushes us into the "advanced" setup use case of calling test-electron functions a little more manually.

I ported the changes from the other upstream projects, to our test runner. And tests are working again. @maliroteh-sf I don't know if you want to take another look or not, at those changes specifically.

@khawkins khawkins merged commit 5d8ed87 into salesforce:main Jun 24, 2024
9 checks passed
@khawkins khawkins deleted the default_prettier branch June 24, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants