Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update sfdx command to sf to match dependent command id change #66

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix: update sfdx command to sf to match dependent command id change #66

merged 4 commits into from
Jun 24, 2024

Conversation

ben-zhang-at-salesforce
Copy link
Contributor

salesforcedx-vscode-core changed all sfdx.* command to sf.*. we need to match the change

@ben-zhang-at-salesforce ben-zhang-at-salesforce requested a review from a team as a code owner June 21, 2024 23:44
maliroteh-sf
maliroteh-sf reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@maliroteh-sf maliroteh-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix prettier issues so that CI jobs all pass.

khawkins
khawkins approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@khawkins khawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs npm run prettier:write changes committed, but other than that LGTM!

@ben-zhang-at-salesforce
Copy link
Contributor Author

now this pr is failing with same error as #67

@maliroteh-sf
Copy link
Collaborator

now this pr is failing with same error as #67

@ben-zhang-at-salesforce wait for the fix in #67 to go in, then rebase and you should be good to go.

@ben-zhang-at-salesforce ben-zhang-at-salesforce merged commit 47eae88 into salesforce:main Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliroteh-sf maliroteh-sf maliroteh-sf left review comments

@khawkins khawkins khawkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-zhang-at-salesforce @maliroteh-sf @khawkins