-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with Java 13 #400
Conversation
That's awesome!! |
I don't know if it is relevant for us but people saw bad performance when migrating from Java 8 to 11: |
For anyone continuing to work on this PR, this is the command that I used to run and debug the application:
(it's provided by |
The distribution of the application will probably need to change with this PR too. Since JavaFX 13 is available through Maven directly and the users will not need to install a runtime dependency, it may be worthwhile to switch to building and distributing an uber jar that contains all dependencies. This will require only a standard JRE installation to run Paintera on users' machines without any other prerequisites such as JDK and Maven. |
Addressed by a3bc181. JavaFx now interprets Shift+Scroll as a horizontal scroll, so querying for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some formatting comments and question about jdk 13.
I assume we need to push for a jgo release
src/main/java/bdv/fx/viewer/project/VolatileHierarchyProjectorPreMultiply.java
Outdated
Show resolved
Hide resolved
src/main/java/org/janelia/saalfeldlab/paintera/viewer3d/Scene3DHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/janelia/saalfeldlab/paintera/viewer3d/ViewFrustumCulling.java
Outdated
Show resolved
Hide resolved
Remove jgo commandline instruction; likely to be deprecated soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Currently, Paintera works only with Java 8. If running with Java 9+,
NoClassDefFoundException
will be printed as reported in #398.Some work has been made in this PR to add compatibility with Java 13, which also allows us to use JavaFX 13 and its new API, such as PixelBuffer for writing into JavaFX images directly instead of having to use reflection to do it.
The PR is not ready yet and there is still a few things to do:
Ctrl+Shift+Scroll
doesn't work in 3D viewer anymore for some reason.label-utilities
dependency and possibly others need to be updated to support Java 13.