Skip to content

Bump src/tools/x to Edition 2024 and some cleanups #143767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump src/tools/x to Edition 2024 and some cleanups #143767

wants to merge 3 commits into from
+10 −14

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jul 11, 2025 •
edited by jieyouxu
Loading

  • Some clippy fixes
  • Bump src/tools/x to Edition 2024

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

src/tools/x was changed. Bump version of Cargo.toml in src/tools/x so tidy will suggest installing the new version.

jieyouxu
jieyouxu approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I edited your PR description and title to note that this PR is bumping the crate edition of src/tools/x to Edition 2024. I think that's something useful to highlight (because it can mean functional changes) in future PRs :)

@jieyouxu jieyouxu changed the title Cleanup x Bump src/tools/x to Edition 2024 and some cleanups Jul 11, 2025
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit dcf965d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#143767 - hkBst:cleanup-x, r=jieyouxu
88066c8 
Bump `src/tools/x` to Edition 2024 and some cleanups

- Some clippy fixes
- Bump `src/tools/x` to Edition 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 11, 2025
Closed
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143790 - matthiaskrgr:rollup-hslb9jq, r=matthiaskrgr
5e942ad 
Rollup of 10 pull requests

Successful merges:

 - #142301 (tests: Fix duplicated-path-in-error fail with musl)
 - #143403 (Port several trait/coherence-related attributes the new attribute system)
 - #143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
 - #143647 (Clarify and expand documentation for std::sys_common dependency structure)
 - #143716 (compiler: doc/comment some codegen-for-functions interfaces)
 - #143747 (Add target maintainer information for aarch64-unknown-linux-musl)
 - #143759 (Fix typos in function names in the `target_feature` test)
 - #143767 (Bump `src/tools/x` to Edition 2024 and some cleanups)
 - #143769 (Remove support for SwitchInt edge effects in backward dataflow)
 - #143770 (build-helper: clippy fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#143767 - hkBst:cleanup-x, r=jieyouxu
8c5f3e4 
Bump `src/tools/x` to Edition 2024 and some cleanups

- Some clippy fixes
- Bump `src/tools/x` to Edition 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hkBst @rustbot @jieyouxu @bors