Rollup of 9 pull requests #143810

matthiaskrgr · 2025-07-11T17:45:27Z

Successful merges:

Port several trait/coherence-related attributes the new attribute system #143403 (Port several trait/coherence-related attributes the new attribute system)
fix: correct assertion to check for 'noinline' attribute presence before removal #143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
Capitalize "dag" as "DAG" #143647 (Clarify and expand documentation for std::sys_common dependency structure)
compiler: doc/comment some codegen-for-functions interfaces #143716 (compiler: doc/comment some codegen-for-functions interfaces)
Add target maintainer information for aarch64-unknown-linux-musl #143747 (Add target maintainer information for aarch64-unknown-linux-musl)
Fix typos in function names in the target_feature test #143759 (Fix typos in function names in the target_feature test)
Bump src/tools/x to Edition 2024 and some cleanups #143767 (Bump src/tools/x to Edition 2024 and some cleanups)
Remove support for SwitchInt edge effects in backward dataflow #143769 (Remove support for SwitchInt edge effects in backward dataflow)
build-helper: clippy fixes #143770 (build-helper: clippy fixes)

r? @ghost
@rustbot modify labels: rollup

…ore removal

This requires digging up ffee956 and reading the comments there to understand that the callee in resolve_closure previously directly handled a function pointer value.

Signed-off-by: Jens Reidel <[email protected]>

Fix a mix-up of a block with its predecessors in handling of SwitchInt edge effects for backward analysis. Note that this functionality is currently unused, so change has no practical impact.

Partially documents the situation due to LLVM CFI.

Those effects are untested and unused. Remove them along with the implementation of `BasicBlocks::switch_sources`.

…jdonszelmann Port several trait/coherence-related attributes the new attribute system Part of rust-lang#131229 This ports: - `#[const_trait]` - `#[rustc_deny_explicit_impl]` - `#[rustc_do_not_implement_via_object]` - `#[rustc_coinductive]` - `#[type_const]` - `#[rustc_specialization_trait]` - `#[rustc_unsafe_specialization_marker]` - `#[marker]` - `#[fundamental]` - `#[rustc_paren_sugar]` - `#[rustc_allow_incoherent_impl]` - `#[rustc_coherence_is_core]` This also changes `#[marker]` to error on duplicates instead of warning. cc rust-lang#142838, but I don't think it matters too much, since it's unstable. r? ``@oli-obk``

fix: correct assertion to check for 'noinline' attribute presence before removal

Clarify and expand documentation for std::sys_common dependency structure This PR makes a minor improvement to the module-level documentation of std::sys_common: Replaces the lowercase “dag” with the more standard and explicit form “DAG (Directed Acyclic Graph)” for clarity.

…en-backend-stuff, r=bjorn3,fee1-dead compiler: doc/comment some codegen-for-functions interfaces An out-of-date comment gets updated and some underdocumented functions get documented.

… r=jieyouxu Add target maintainer information for aarch64-unknown-linux-musl Mentioning ``@famfo`` so that they can review the documentation. We're both very invested in this target; I originally promoted it to tier 2 with host tools in rust-lang#76420 back in 2020.

Remove support for SwitchInt edge effects in backward dataflow Those effects are untested and unused. Remove them along with the implementation of `BasicBlocks::switch_sources`.

build-helper: clippy fixes

matthiaskrgr · 2025-07-11T17:45:40Z

@bors r+ rollup=never p=4

bors · 2025-07-11T17:45:43Z

📌 Commit 324bc31 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-07-12T10:46:47Z

⌛ Testing commit 324bc31 with merge 915e535...

bors · 2025-07-12T13:47:29Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 915e535 to master...

rust-timer · 2025-07-12T13:50:02Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#143403	Port several trait/coherence-related attributes the new att…	`496704347c3a44874ff19546271c85e555c34b6b` (link)
#143633	fix: correct assertion to check for 'noinline' attribute pr…	`8659a1c9641d5a760b10b6a77e6412b5f90f06b2` (link)
#143647	Clarify and expand documentation for std::sys_common depend…	`876edbb89fc0aab1c0e65fa0d4d96d7236b43535` (link)
#143716	compiler: doc/comment some codegen-for-functions interfaces	`9b3c2b20d834e2f688ee7ba236313beef65495cc` (link)
#143747	Add target maintainer information for aarch64-unknown-linux…	`22e4361562e6da20403701f2d4657c5ffbc26bed` (link)
#143759	Fix typos in function names in the `target_feature` test	`055b2f5c1f8932c2310fb527be3d7e70b669c1e5` (link)
#143767	Bump `src/tools/x` to Edition 2024 and some cleanups	`3cec1f24119de3ac84730981fc9227387017fe7a` (link)
#143769	Remove support for SwitchInt edge effects in backward dataf…	`c266cd4b9a3aca6b6b074687ac56a8688d217ff1` (link)
#143770	build-helper: clippy fixes	`75f029a039d302000827817a60846e1a2230c204` (link)

previous master: 2f9c9cede6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-12T13:50:08Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2f9c9ce (parent) -> 915e535 (this PR)

Test differences

Show 10 test diffs

10 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 915e5352448afb3c24f89117468935283bc7d2cf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

tidy: 75.4s -> 100.7s (33.6%)
x86_64-apple-2: 5279.9s -> 3910.5s (-25.9%)
x86_64-apple-1: 5989.5s -> 7098.6s (18.5%)
dist-apple-various: 5714.4s -> 6730.7s (17.8%)
dist-x86_64-apple: 8021.7s -> 7334.0s (-8.6%)
aarch64-apple: 4625.6s -> 4978.9s (7.6%)
dist-aarch64-apple: 5670.1s -> 5286.1s (-6.8%)
x86_64-msvc-2: 7089.5s -> 6661.6s (-6.0%)
aarch64-gnu: 6978.7s -> 6589.5s (-5.6%)
arm-android: 6288.5s -> 6629.4s (5.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-12T14:57:54Z

Finished benchmarking commit (915e535): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	34
Regressions ❌ (secondary)	0.4%	[0.0%, 1.0%]	33
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.3%, -0.0%]	3
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	34

Max RSS (memory usage)

Results (primary -0.9%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[1.4%, 5.6%]	2
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-2.7%	[-6.6%, -1.6%]	6
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Cycles

Results (primary -1.8%, secondary -7.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.2%	[4.2%, 4.2%]	1
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-2.8%	[-3.9%, -2.2%]	6
Improvements ✅ (secondary)	-8.8%	[-11.7%, -4.6%]	7
All ❌✅ (primary)	-1.8%	[-3.9%, 4.2%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.356s -> 466.126s (0.82%)
Artifact size: 374.66 MiB -> 374.63 MiB (-0.01%)

dillona and others added 30 commits July 8, 2025 06:24

fix: correct assertion to check for 'noinline' attribute presence bef…

b2299e2

…ore removal

Port #[const_trait] to the new attribute system

62f58db

Port #[rustc_deny_explicit_impl] to the new attribute system

938916d

Port #[rustc_do_not_implement_via_object] to the new attribute system

adb325f

Port #[rustc_coinductive] to the new attribute system

6f8e92d

Port #[type_const] to the new attribute system

813ec60

Port #[rustc_specialization_trait] to the new attribute system

6193783

Port #[rustc_unsafe_specialization_marker] to the new attribute system

a57a885

Port #[marker] to the new attribute system

12f6487

Port #[fundamental] to the new attribute system

507ebce

Port #[rustc_paren_sugar] to the new attribute system

1bdf703

Reorder attribute parsers in traits.rs

a6bc816

Port #[rustc_allow_incoherent_impl] to the new attribute system

e9e6495

Port #[rustc_coherence_is_core] to the new attribute system

e584ed0

compiler: recomment needs_fn_once_adapter_shim

04bb68a

This requires digging up ffee956 and reading the comments there to understand that the callee in resolve_closure previously directly handled a function pointer value.

Add target maintainer information for aarch64-unknown-linux-musl

a866377

Signed-off-by: Jens Reidel <[email protected]>

fix typos in function names in the target_feature test

ed96f00

docs: clarify “dag” in std::sys_common doc comment

3c11029

x: clippy fixes

2861274

x: move to edition 2024

b87a1b1

x: use let-else

dcf965d

Call get_switch_int_data on a block with SwitchInt terminator

011d4aa

Fix a mix-up of a block with its predecessors in handling of SwitchInt edge effects for backward analysis. Note that this functionality is currently unused, so change has no practical impact.

build-helper: clippy fixes

ba3b7a7

compiler: comment on some call-related codegen fn in cg_ssa

39f7707

Partially documents the situation due to LLVM CFI.

Remove support for SwitchInt edge effects in backward dataflow analyses

5b6d661

Those effects are untested and unused. Remove them along with the implementation of `BasicBlocks::switch_sources`.

Rollup merge of rust-lang#143633 - dillona:noinline-assert, r=fee1-dead

7f3204f

fix: correct assertion to check for 'noinline' attribute presence before removal

Rollup merge of rust-lang#143716 - workingjubilee:document-some-codeg…

b18064f

…en-backend-stuff, r=bjorn3,fee1-dead compiler: doc/comment some codegen-for-functions interfaces An out-of-date comment gets updated and some underdocumented functions get documented.

matthiaskrgr added 2 commits July 11, 2025 19:45

Rollup merge of rust-lang#143769 - tmiasko:rm-backward-switch-int, r=lqd

1d2aa4d

Remove support for SwitchInt edge effects in backward dataflow Those effects are untested and unused. Remove them along with the implementation of `BasicBlocks::switch_sources`.

Rollup merge of rust-lang#143770 - hkBst:build-helper-cleanup, r=Kobzol

324bc31

build-helper: clippy fixes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 12, 2025

bors merged commit 915e535 into rust-lang:master Jul 12, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 12, 2025

This was referenced Jul 12, 2025

Cache MIR preorder traversal. #142578

Draft

rustdoc-json: Structured attributes #142936

Open

Replace JSONPath with jq in jsondocck #143089

Draft

rustbot added the perf-regression Performance regression. label Jul 12, 2025

This was referenced Jul 12, 2025

Port #[automatically_derived] to the new attribute parsing infrastructure #143779

Open

Fix ICE caused by parsed attributes applied to where bounds #143781

Open

Port #[should_panic] to the new attribute parsing infrastructure #143808

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #143810

Rollup of 9 pull requests #143810

matthiaskrgr commented Jul 11, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jul 11, 2025

Uh oh!

bors commented Jul 11, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 12, 2025

Uh oh!

github-actions bot commented Jul 12, 2025

Uh oh!

rust-timer commented Jul 12, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #143810

Rollup of 9 pull requests #143810

Conversation

matthiaskrgr commented Jul 11, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jul 11, 2025

Uh oh!

bors commented Jul 11, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 12, 2025

Uh oh!

github-actions bot commented Jul 12, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 12, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Jul 11, 2025 •

edited by rustbot

Loading