-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chapter title and page number info to the book page #40
base: master
Are you sure you want to change the base?
Conversation
Thanks for the patch. One thing I've wanted is some progress That said, I have some concerns about this approach: First, the title and page count should look like they're part of the Along these lines, we'd need to figure out how these would interact I'm not sold on putting the chapter title at the top of each page. In a little bit of testing, I've noticed that the total page count But before we do that, two other ideas:
I'm also going to comment on some of the code inline. This is just to |
@@ -54,9 +54,33 @@ | |||
}); | |||
reader.listen("monocle:pagechange", function(event) { | |||
var place = reader.getPlace(); | |||
|
|||
// Following code taken from Monacle to estimate overall pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling
After some more thought -- this could be something that depends of screen size. On a phone, you probably don't want anything other than text on the page. But on a tablet, you can't (comfortably) fill up the whole screen with text, so we can add these bits to take up some of the room. Already, we're adjusting the margins to account for this. The left and right margins will grow to keep the width of the text block, in characters, about constant. For the first bit, the top and bottom margins grown in proportion. But these are capped at some value (5 and 10%, I think; the bottom is always twice the top). Past that point, we could add in a header and/or footer. Are you interested in working on this further? |
Sorry for the delay - here are my responses to your comments:
|
On the phone, you could use the new bottom-edge gesture to bring up the slider to move around in the book, and then on further dragging up, bring up the table of contents. But normally the title and percent could be hidden by default. |
I wanted this to percolate in my mind for a bit, but then I forgot about it. Sorry. Here are my current thoughts:
Let me know if this seems reasonable and if I can help point you in the right direction on implementation. |
Something that I liked about iBooks that gave it some polish was displaying the book name and page number info on the book page. So, I've done the same (though using chapter title instead).