-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a page slider to the contents menu... #77
base: master
Are you sure you want to change the base?
Add a page slider to the contents menu... #77
Conversation
…to a place in the book rather than having to skip through page by page
Thanks for the patch. If I'm understanding it correctly, the slider Pull request #40 offers another approach for calculating page numbers, Also, I should let you know that I've been toying with a redesign of [1] https://plus.google.com/108747901910183509998/posts/J3aipVzr3vX |
Nope. Based on my, admittedly limited, testing it works in the whole book, On Wednesday, 4 March 2015, Robert Schroll [email protected] wrote:
New Year's Day -- |
For Project Gutenberg books, it gives the full book. But on some It's terribly formatted, admittedly, but checkout this edition of Huck |
Huh. That's a Monocle bug, then, not that that's an excuse. I'll take a On Wednesday, 4 March 2015, Robert Schroll [email protected] wrote:
New Year's Day -- |
I suspect that Monocle is working as designed, though that may not be I don't know if you've seen it, but Monocle has a build-in scrubber Alternatively, I noticed that it was actually rather convenient to have |
OK. I have tested the Twain book, and I agree; Monocle is reporting misleading page data. Bah, and again bah. It'd be worth looking at the Monocle built-in scrubber to get page data, although "find whoever made it report page data as though it applied to the whole book even though it is html-file specific and then punch them in the throat" is a roughly equal approach. Seriously, monocle reports page data. It should not report that incorrectly, and if that's even remotely fixable, we should fix it. |
Forgot the link to the scrubber code: I think the problem is that the only way to get the total page count is Looking through the Place API, I note the percentageOfBook() and |
Ya; I'm using the percentage, as per stuartlangridge@6be320f#diff-26aeb1b8786cc0911ac0c0bd03e55d41R660 to calculate the total number of pages; we get a pageSizePercentage and a percentageThrough and get the total number of pages as 1/pageSizePercentage. I ask Monocle for the page number too but in theory I don't have to. This all feels doable to me, although perhaps it needs more thought than I've thought :) |
I now see what you're getting at. The weights thing will need calculating, indeed, I think, from file sizes. I'll take a look at how we might do that. |
QuaZipFileInfo has a uncompressedSize attribute that will probably be |
I have pushed an updated branch which uses uncompressedSize, but don't merge it. It doesn't work all that reliably. Specifically, short chapters which nonetheless contain a few pages (things such as cover pages, introductions, and the like) sod up the calculations something dramatic. I'm not sure how best to resolve this, other than to have the C stuff contain a copy of the paging algorithm, calculate a (reasonably) accurate number of pages, and then calculate componentWeights based on that. This is exceedingly frustrating. Perhaps the slider should just work on percentages or something, rather than trying to be clever with page counts? The goal here is to be able to jump roughly to a place in the book, rather than having to hit the page next button four hundred times to do so; moving to "page 411" is rarely what's actually wanted, especially since page numbers are close to meaningless in an ebook anyway...? |
I think this is essentially the same problem we were having over in #40. A few disorganized thoughts follow:
|
...which allows someone to jump to a place in the book directly rather than having to skip through page by page. I find myself missing this a lot.