Repository navigation
Conversation
…ame path find_game_install_path returned the first existing folder, starting from the main Steam library. A leftover folder with the same name (backups and test files Steam does not remove on uninstall) won over the real install in a secondary library, so Danganronpa was scanned in the wrong place and ended with "no strings translated". Look up the library whose appmanifest declares that installdir first, and fall back to the previous search otherwise. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
find_game_install_path(src-tauri/src/commands/steam_enhanced.rs) now looks first for the Steam library whoseappmanifest_*.acfdeclares the requestedinstalldir, and returns that folder. The previous search (main library, secondary libraries, normalized name match, guessedD:\/E:\paths) is kept as the fallback.The new helper
manifest_backed_install_pathcompares names with the existingnormalize_install_dir, so it also works when the caller passes the game name instead of the folder name.Why
The function returned the first folder that existed, starting from the main Steam library. Steam leaves non-Steam files behind on uninstall, so a leftover folder with the same name won over the real install in a secondary library.
Measured on Danganronpa: Trigger Happy Havoc: the game is installed in a secondary library, but the main library still had a same-named folder holding only old
.gsbackupfiles and an extracted test directory. The one-click translate page scanned that folder, found a single stray file with 52 strings, and ended with "no strings translated".Testing
appmanifest_batte_la_cartella_residuareproduces the case with two fake libraries in a temp dir.cargo test --bin gamestringer tests_install_path: 3 passed.Reviewer notes
gamestringer.exe, so only the unit tests ran.appmanifest_*.acfin each library on every call (small files, one per installed game).docs/METODI-DI-TRADUZIONE.mdgets an entry describing the finding, as the project conventions require.🤖 Generated with Claude Code