Remove Tf2 time tutorials for Python #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
added
the
backport-all
ahcorde
approved these changes
May 7, 2024
|
I openned an issue #4385 |
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be)
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be)
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be) # Conflicts: # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Cpp.rst # source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Py.rst # source/Tutorials/Intermediate/Tf2/Learning-About-Tf2-And-Time-Py.rst # source/Tutorials/Intermediate/Tf2/Time-Travel-With-Tf2-Py.rst # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Broadcaster-Cpp.rst # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Broadcaster-Py.rst # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Py.rst
This was referenced May 7, 2024
This was referenced May 7, 2024
clalancette
added a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be) Co-authored-by: Chris Lalancette <[email protected]>
clalancette
added a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be) Co-authored-by: Chris Lalancette <[email protected]>
clalancette
added a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be)
clalancette
added a commit
that referenced
this pull request
May 7, 2024
* Small update for language in tf2 static transforms. * Small language fixups in tf2 broadcaster tutorials. * Small language updates in Writing a tf2 listener. * Small clarification in Add-a-frame tutorials. * Small updates to the Learning-about-tf2-and-time-cpp tutorial. * Remove the python tf2 tutorials. They have not worked for a very long time, and in point of fact with the current tf2_py code, they cannot work. Remove them until the time we actually fix the tf2_py code, at which point we can reintroduce them. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit cb0e0be) Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 4 tutorials having to do with time for tf2:
C++:
Python:
The C++ ones work fine, and have worked fine since approximately forever. This PR does some small cleanups in those tutorials, but otherwise leaves them alone.
The Python ones are a different story. Due to some bugs in
tf2_pyitself, those tutorials have never worked in ROS 2. The correct solution here would be to fix uptf2_pyto make them work, but that hasn't yet happened. Thus, I think it is better to remove those tutorials than to continue to provide them in a non-working state. So this PR does exactly that.It also has some other random small fixups throughout the tf2 tutorials.
Edit: this also "fixes" #3960 and #3080 and #2935 , by removing the offending tutorial completely.