Remove Tf2 time tutorials for Python (backport #4384) #4388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 4 tutorials having to do with time for tf2:
C++:
Python:
The C++ ones work fine, and have worked fine since approximately forever. This PR does some small cleanups in those tutorials, but otherwise leaves them alone.
The Python ones are a different story. Due to some bugs in
tf2_py
itself, those tutorials have never worked in ROS 2. The correct solution here would be to fix uptf2_py
to make them work, but that hasn't yet happened. Thus, I think it is better to remove those tutorials than to continue to provide them in a non-working state. So this PR does exactly that.It also has some other random small fixups throughout the tf2 tutorials.
Edit: this also "fixes" #3960 and #3080 and #2935 , by removing the offending tutorial completely.
This is an automatic backport of pull request #4384 done by Mergify.