Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to install binaries and connect to multiple hosts #443

Merged
merged 12 commits into from
Feb 6, 2025

Conversation

PaulBouchier
Copy link
Contributor

@PaulBouchier PaulBouchier commented Feb 2, 2025

Improve README.md by correcting mis-ordering of killing other rmw's. Also clarify procedure for modifying router config file

Fix #442

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some minor feedback!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
PaulBouchier and others added 3 commits February 4, 2025 20:46
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
@PaulBouchier
Copy link
Contributor Author

Approved requested changes

@PaulBouchier
Copy link
Contributor Author

I added binary installation to the README.md PR.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
PaulBouchier and others added 4 commits February 5, 2025 12:32
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>
@PaulBouchier
Copy link
Contributor Author

Agree with all suggestions & accepted. Thank you!

Signed-off-by: Yadunund <[email protected]>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to push some minor tweaks and LGTM!

@Yadunund Yadunund changed the title Close issue #442 Update documentation to install binaries and connect to multiple hosts Feb 6, 2025
@Yadunund Yadunund merged commit 12f8344 into ros2:rolling Feb 6, 2025
5 checks passed
@Yadunund
Copy link
Member

Yadunund commented Feb 6, 2025

@Mergifyio backport jazzy humble

Copy link

mergify bot commented Feb 6, 2025

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 6, 2025
#443)

* Improve README.md

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Document installation from binaries

* Update README.md

Fix formatting error

Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Paul Bouchier <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit 12f8344)
mergify bot pushed a commit that referenced this pull request Feb 6, 2025
#443)

* Improve README.md

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Document installation from binaries

* Update README.md

Fix formatting error

Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Co-authored-by: yadunund <[email protected]>
Signed-off-by: Paul Bouchier <[email protected]>

* Update README.md

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Paul Bouchier <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Co-authored-by: yadunund <[email protected]>
(cherry picked from commit 12f8344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md has bringup order wrong, & unclear on connecting multiple hosts
2 participants