-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to install binaries and connect to multiple hosts #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left some minor feedback!
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Approved requested changes |
Fix formatting error Signed-off-by: Paul Bouchier <[email protected]>
I added binary installation to the README.md PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more feedback!
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]>
Agree with all suggestions & accepted. Thank you! |
Signed-off-by: Yadunund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to push some minor tweaks and LGTM!
@Mergifyio backport jazzy humble |
✅ Backports have been created
|
#443) * Improve README.md * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Document installation from binaries * Update README.md Fix formatting error Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Paul Bouchier <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: yadunund <[email protected]> (cherry picked from commit 12f8344)
#443) * Improve README.md * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Document installation from binaries * Update README.md Fix formatting error Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Co-authored-by: yadunund <[email protected]> Signed-off-by: Paul Bouchier <[email protected]> * Update README.md Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Paul Bouchier <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: yadunund <[email protected]> (cherry picked from commit 12f8344)
Improve README.md by correcting mis-ordering of killing other rmw's. Also clarify procedure for modifying router config file
Fix #442