Don't close Zenoh session while the process is terminating. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evshary
force-pushed
the
fix_panic_while_closing
branch
from
4865bbd to
006ae77
Compare
|
Now that we've merged in #327 (changing to zenoh-cpp), this needs a rebase. I'm going to mark this as a draft until then. Once it has been rebased onto the latest, we'll do a full review. |
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
evshary
force-pushed
the
fix_panic_while_closing
branch
from
006ae77 to
d3a9a51
Compare
|
We are not using ZenohSession anymore in the current implementation. I think we need to find another solution for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR comes from the proposal here #324
Before figuring out a better solution, we can use this to avoid the panic issue.