Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move qos_profile_rosout_default to rmw. #1195

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

move qos_profile_rosout_default to rmw. #1195

wants to merge 3 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

depends on ros2/rmw#381

@fujitatomoya fujitatomoya mentioned this pull request Nov 6, 2024
Open
This was referenced Nov 6, 2024
Open
Open
@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rclpy#1376, ros2/rmw#381, #1195, ros2/rclcpp#2663
Gist: https://gist.githubusercontent.com/fujitatomoya/e4ad476b64d3f274940ae31ebe7149e3/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy rmw rcl rclcpp
TEST args: --packages-above rclpy rmw rcl rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14837

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 5716579 to 43e33ee Compare January 18, 2025 01:13
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/node-rosout-qos-profile-support branch from 43e33ee to f9ef0ba Compare January 22, 2025 20:28
@fujitatomoya
Copy link
Collaborator Author

Pulls: #1195, ros2/rmw#381, ros2/rclcpp#2663, ros2/rclpy#1376
Gist: https://gist.githubusercontent.com/fujitatomoya/259af27c06fabca14048f5367b8552af/raw/2fa0833cd5e3edd9602385b88d556cb0d18ad054/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15081

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

https://ci.ros2.org/job/ci_windows/23193/console windows is not happy with C:\ci\ws\src\ros2\rcl\rcl\include\rcl/logging_rosout.h(41,95): error C2099: initializer is not a constant (compiling source file C:\ci\ws\src\ros2\rcl\rcl\src\rcl\logging.c).

@fujitatomoya
make windows happy.
cf86132 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Jan 22, 2025 •
edited
Loading

Pulls: #1195, ros2/rmw#381, ros2/rclcpp#2663, ros2/rclpy#1376
Gist: https://gist.githubusercontent.com/fujitatomoya/94630b0c6cc669a66b03c18a1487f1d8/raw/eda21354a124f2ef7073c211f8325ed696bb886a/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rcl rclcpp rclpy
TEST args: --packages-above rmw rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15082

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@audrow audrow Awaiting requested review from audrow

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @ahcorde