Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wildcards #369

Open
wants to merge 7 commits into
base: rolling
Choose a base branch
from

Conversation

iuhilnehc-ynos
Copy link

Chen Lihui added 2 commits July 13, 2023 10:49
@iuhilnehc-ynos iuhilnehc-ynos marked this pull request as draft July 13, 2023 02:55
Chen Lihui added 5 commits July 13, 2023 11:19
Signed-off-by: Chen Lihui <[email protected]>
and use fullmatch instead

Signed-off-by: Chen Lihui <[email protected]>
This reverts commit aae8499.

Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
@tonynajjar
Copy link

tonynajjar commented Jul 25, 2023

hey @iuhilnehc-ynos, thanks for working on this! is this ready? I could give it a quick test for my application and give feedback

@iuhilnehc-ynos
Copy link
Author

@tonynajjar I have some other PRs in my hand. I suppose that another one, which was pushed before this PR, will be reviewed in the coming days. Therefore, I marked this PR as a draft.

I would appreciate it if you could give it a try. Any feedback is welcome.

@iuhilnehc-ynos iuhilnehc-ynos marked this pull request as ready for review July 25, 2023 09:02
@tonynajjar
Copy link

tonynajjar commented Jul 25, 2023

I'm on Humble so I just copied your changes to to_parameters_list.py and that did the trick! With this PR, my composable node was able to read a yaml file as such:

/**:
  controller_server:
    ros__parameters:
      speed_limit_topic: "speed_limit"
      odom_topic: odometry/filtered
      ....

  behavior_server:
    ros__parameters:
      costmap_topic: local_costmap/costmap_raw
      footprint_topic: local_costmap/published_footprint
      ......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants