-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support wildcards #369
base: rolling
Are you sure you want to change the base?
support wildcards #369
Conversation
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
and use fullmatch instead Signed-off-by: Chen Lihui <[email protected]>
This reverts commit aae8499. Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
hey @iuhilnehc-ynos, thanks for working on this! is this ready? I could give it a quick test for my application and give feedback |
@tonynajjar I have some other PRs in my hand. I suppose that another one, which was pushed before this PR, will be reviewed in the coming days. Therefore, I marked this PR as a draft. I would appreciate it if you could give it a try. Any feedback is welcome. |
I'm on Humble so I just copied your changes to
|
to address ros2/rclcpp#1265 (comment)